Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting heights twice within 0.1s #1823

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

hanayashiki
Copy link
Contributor

Fixes #1809

@sandy2008
Copy link

sandy2008 commented Jun 3, 2020

👍 Wow, this fix the keyboard issue once and for all.

src/GiftedChat.tsx Outdated Show resolved Hide resolved
src/GiftedChat.tsx Outdated Show resolved Hide resolved
hanayashiki and others added 2 commits June 3, 2020 14:24
Co-authored-by: Xavier Carpentier <[email protected]>
Co-authored-by: Xavier Carpentier <[email protected]>
@hanayashiki
Copy link
Contributor Author

Thank you for your advice!

@xcarpentier xcarpentier merged commit 3c24043 into FaridSafi:master Jun 3, 2020
@hirbod
Copy link
Contributor

hirbod commented Jun 25, 2020

Well this PR introduces this for me @xcarpentier @hanayashiki
https://streamable.com/mw4eup

I think it was there for a reason. When I remove this patch using patch-package, everything works fine again

U see a fast refresh in my video, I loaded the patched version there and then its working fine again.

@xcarpentier
Copy link
Collaborator

Ok I will revert it in the next patch version.

@xcarpentier
Copy link
Collaborator

xcarpentier commented Jun 26, 2020

Hi @hirbod it reverts then fixed into v016.3
And thanks for your excellent report!

Please take a look at the next MAJOR version in this PR: #1775
We need such a kind of report ;)

@hirbod hirbod mentioned this pull request Jul 1, 2020
@fierysolid
Copy link

Is this library getting new support?! Very happy right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unwanted bottom padding in InputToolbar when Keyboard open
5 participants